"i haven't tested this but it looks slow" well it's not, please SHUT UP
Yeah, this is the gist of it. They came with a bunch of recommendations on how to improve performance, but hadn't actually run the code at all. I won't go into too much detail, but the recommendations were sketchy at best.
I was also named specifically, in an email that went to several of my colleagues, as not caring about quality control because I tend to commit additional fixes after opening a pull request, but before merging. Coincidentally, this person works for one of those companies that can't for the life of them find developers despite high revenue.
nothing encourages constructive professional development like public shaming
If sending a pull request and then noticing a small problem and fixing it while it's out for review is a crime, then LOCK ME UP, officer.
Also how do you do a performance and scalability review and not primarily base that on profiling and stuff. I gotta get in to this business, just kinda eyeball the codebase and go based on vibes.
i'll let you know if i see an open position for backseat developer
neku wrote
i dont know anything about programming but are you saying that this person looked at your code, didnt bother running it, and was like "🤔 looks like its not good enough"